Alvaro Herrera <alvherre@xxxxxxxxxxxxxxx> writes: > Seems that ExecHashJoinGetSavedTuple stores a minimalTuple and sets the > shouldFree flag to "true", and then in ExecHashJoinNewBatch, callee > ExecFetchSlotMinimalTuple sets shouldFree to false inconditionally when > the slot uses minimal tuple ops. Maybe that's correct, but it does > sound like a memory leak is not entirely impossible. I wonder if this > fixes it, without causing crashes elsewhere. This discussion is about v11, not HEAD. Still, I agree that that coding in HEAD seems a bit fishy. regards, tom lane
