On 2024/12/29 11:29, Leonardo Brás wrote: > Gitlab-CI is failing[1] on building CodeSamples due to liburcu v0.15 > deprecating[2] support for liburcu-signal: > > %%% > * Deprecation of liburcu-signal > > Users can migrate to liburcu-memb with a kernel implementing the > membarrier(2) system call to have similar read-side performance without > requiring use of a reserved signal, and with improved grace period > performance. > %%% > > So, in order to avoid breaking builds with liburcu >=0.15 while keeping > support for older systems without sys_membarrier(), check for the existance > of liburcu-signal before adding it to the build command. Thank you! This is elegant. Tested OK against Ubuntu 20.04 LTS, Ubuntu 24.04, and Fedora 41. > > Signed-off-by: Leonardo Bras <leobras.c@xxxxxxxxx> Filling in missing link tags from v2 so that Paul can apply. Link: https://gitlab.com/linux-kernel/perfbook/-/jobs/8732944799 [1] Link: https://lists.lttng.org/pipermail/lttng-dev/2024-December/030893.html [2] Reviewed-by: Akira Yokosawa <akiyks@xxxxxxxxx> Tested-by: Akira Yokosawa <akiyks@xxxxxxxxx> > --- > CodeSamples/datastruct/Issaquah/Makefile | 5 ++-- > CodeSamples/datastruct/existence/Makefile | 34 ++++++++++++----------- > CodeSamples/datastruct/hash/Makefile | 7 +++-- > CodeSamples/datastruct/skiplist/Makefile | 5 ++-- > CodeSamples/defer/Makefile | 7 +++-- > 5 files changed, 32 insertions(+), 26 deletions(-) > Thanks, Akira
