On Sat, 2024-01-06 at 10:15 +0900, Akira Yokosawa wrote: > Hi Leo, > > On Fri, 05 Jan 2024 18:39:15 -0300, Leonardo Brás wrote: > > On Fri, 2024-01-05 at 18:58 +0900, Akira Yokosawa wrote: > > > On Arch Linux, rsvg-convert is provided in the librsvg package. > > > Install it instead of inkscape. > > > > > > Using rsvg-convert can shorten runtime of CI job for building PDFs > > > a bit. > > > > > > Signed-off-by: Akira Yokosawa <akiyks@xxxxxxxxx> > > > Cc: Leonardo Bras <leobras.c@xxxxxxxxx> > > > --- > > > > Hello Akira, > > > > I used the leobras-ci branch from gitlab/linux_kernel/perfbook to test your > > patchset: > > https://gitlab.com/linux-kernel/perfbook/-/jobs/5872530547 > > Thank you for taking the time! > > > > > It generated the pdf successfully, could you check if the images were generated > > correctly? > > https://gitlab.com/linux-kernel/perfbook/-/jobs/5872530547/artifacts/browse > > Looks good to me. > Amazing! so Tested-by: Leonardo Bras <leobras.c@xxxxxxxxx> > > > > > Needs an explicit ACK or Tested-by from Leo. > > > Expected order of reduction of build time: ~10s > > And the job took 11m53s. > Previous runs: 13m29s, 12m57s, 13m50s, 13m45s, 12m26s ... > Not installing inkscape should also help reduce the time. > Yeah, it's a pretty big suite, you are most probably correct. > > > > > > utilities/gitlab-ci.yml | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/utilities/gitlab-ci.yml b/utilities/gitlab-ci.yml > > > index bcda8712..17525fb4 100644 > > > --- a/utilities/gitlab-ci.yml > > > +++ b/utilities/gitlab-ci.yml > > > @@ -19,7 +19,7 @@ generate_pdfs: > > > stage: build > > > > > > before_script: > > > - - pacman --noconfirm -Syu texlive-meta fig2dev ghostscript graphviz inkscape wget make which fontconfig git ttf-dejavu gnu-free-fonts ttf-liberation > > > + - pacman --noconfirm -Syu texlive-meta fig2dev ghostscript graphviz librsvg wget make which fontconfig git ttf-dejavu gnu-free-fonts ttf-liberation > > > > so s/inkscape/librsvg/ right? > > Yes. > > > > > It's fine by me. > > May I take that as your Acked-by: ? > Sure: Acked-by: Leonardo Bras <leobras.c@xxxxxxxxx> > Thanks, Akira > Thank you! Leo > > > > Thanks! > > Leo > > > > > - mkdir -p ~/.local/share/fonts && cp fonts/steel-city-comic.regular.ttf ~/.local/share/fonts/ && fc-cache > > > > > > script: > >
