Thank Akira's valuable advice
On Wed, Dec 27, 2023 at 12:53 PM Akira Yokosawa <akiyks@xxxxxxxxx> wrote:
>
> Hi Zhouyi,
>
> [Dropping YunJing Li's unreachable address]
>
> On Wed, 27 Dec 2023 10:49:54 +0800, zhouzhouyi@xxxxxxxxx wrote:
> > From: 周洲仪 <8241764+zhouyizhousihai@xxxxxxxxxxxxxxxxxxxxxx>
>
> No, we can't accept a patch from an author whose email address is
> unreachable (tested from my gmail account).
> Please use YunJing Li's globally accessible email address please
> if you would like to keep the credit.
I contact YunJing Li in the morning, she is being too modest to be a
patch author, because she think to improve Chinese edition is her job
;-)
>
> >
> > According to our Chinese version editor Yunjing Li's advice,
> > make reference to perfbook's git archive explicit.
>
> Please describe what Yunjins Li's advice was.
> Honestly speaking, I don't see much point in this update.
Yunjin Li's original advice was "Can we make 'git archive' in answer
to Quick Quiz 1.3 more explicit, so that reader can easily know where
'git archive' is"
>
> >
> > Signed-off-by: Zhouyi Zhou<zhouzhouyi@xxxxxxxxx>
>
> We need a Signed-off-by: tag from the author as well ...
>
> One more minor nit below:
>
> > ---
> > bib/syncrefs.bib | 8 ++++++++
> > howto/howto.tex | 2 +-
> > legal.tex | 5 ++---
> > 3 files changed, 11 insertions(+), 4 deletions(-)
> >
> > diff --git a/bib/syncrefs.bib b/bib/syncrefs.bib
> > index 6ee50e3b..4f347488 100644
> > --- a/bib/syncrefs.bib
> > +++ b/bib/syncrefs.bib
> > @@ -2025,3 +2025,11 @@ Parallel Server on UNIX",
> > Month="September",
> > Note="Linux Plumbers Conference \url{https://lpc.events/event/16/contributions/1226/}";,
> > }
> > +
> > +@unpublished{PaulmckPerfbookGit,
> > + author="Paul E. McKenney",
> > + title="Is Parallel Programming Hard, And, If So, What Can You Do About It? Git Archive",
> > + year="2023",
> > + note={\url{git://git.kernel.org/pub/scm/linux/kernel/git/paulmck/perfbook.git}},
> > + lastchecked="December 27, 2023",
> > +}
> > \ No newline at end of file
>
> Need to be fixed.
OK, I will fix this
>
> > diff --git a/howto/howto.tex b/howto/howto.tex
> > index 55270cba..e7cd5f3c 100644
> > --- a/howto/howto.tex
> > +++ b/howto/howto.tex
> > @@ -226,7 +226,7 @@ Here are a few possible strategies:
> > only a blank sheet of paper.
> > \item If you find the Quick Quizzes distracting but impossible
> > to ignore, you can always clone the \LaTeX{} source for
> > - this book from the git archive.
> > + this book from the git archive~\cite{PaulmckPerfbookGit}.
> > You can then run the command \co{make nq}, which will
> > produce a \co{perfbook-nq.pdf}.
> > This PDF contains unobtrusive boxed tags where the Quick Quizzes
> > diff --git a/legal.tex b/legal.tex
> > index f443df37..ca21ecaf 100644
> > --- a/legal.tex
> > +++ b/legal.tex
> > @@ -42,12 +42,11 @@ Source code is covered by various versions of the GPL\@.\footnote{
> > Some of this code is GPLv2-only, as it derives from the Linux kernel,
> > while other code is GPLv2-or-later.
> > See the comment headers of the individual source files within the
> > -CodeSamples directory in the git archive\footnote{
> > - \url{git://git.kernel.org/pub/scm/linux/kernel/git/paulmck/perfbook.git}}
> > +CodeSamples directory in the git archive~\cite{PaulmckPerfbookGit}
>
> I think Legal pages should better be self-contained if at all possible.
> IOW, the URL should better be somewhere in the Legal pages.
>
OK, I will keep the Legal pages unchanged.
> > for the exact licenses.
> > If you are unsure of the license for a given code fragment,
> > you should assume GPLv2-only.
> >
> > Combined work {\textcopyright}~2005--\commityear\ by Paul E. McKenney.
> > Each individual contribution is copyright by its contributor at the time
> > -of contribution, as recorded in the git archive.
> > +of contribution, as recorded in the git archive~\cite{PaulmckPerfbookGit}.
>
> Do we really need this?
OK, I will keep this unchanged as well.
>
> Regards, Akira
I will prepare the new version of patch soon.
Thanks again
Regards, Zhouyi
>
> > --
> > 2.34.1
> >
>
