Hi Alan, On Sun, 21 May 2023 16:24:17 +0000, Alan Huang wrote: > The two references are misplaced, this patch fixes that. Nice catches! As I made the mistake in commit 30db63ed4177 ("formal/dyntickrcu: Cite git commits of dyntickrcu fixes"), let me add a Fixes: tag along with my R-b. Fixes: 30db63ed4177 ("formal/dyntickrcu: Cite git commits of dyntickrcu fixes") Reviewed-by: Akira Yokosawa <akiyks@xxxxxxxxx> Thanks, Akira > > Signed-off-by: Alan Huang <mmpgouride@xxxxxxxxx> > --- > formal/dyntickrcu.tex | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/formal/dyntickrcu.tex b/formal/dyntickrcu.tex > index 42c0c55c..2d118e69 100644 > --- a/formal/dyntickrcu.tex > +++ b/formal/dyntickrcu.tex > @@ -1132,7 +1132,7 @@ This effort provided some lessons (re)learned: > In this case, the documentation effort located > a misplaced memory barrier in > \co{rcu_enter_nohz()} and \co{rcu_exit_nohz()}, > - as shown by the following patch~\cite{PaulEMcKenney2008commit:d7c0651390b6}. > + as shown by the following patch~\cite{PaulEMcKenney2008commit:ae66be9b71b1}. > > \begin{VerbatimU} > static inline void rcu_enter_nohz(void) > @@ -1155,7 +1155,7 @@ This effort provided some lessons (re)learned: > This effort located one subtle bug in > \co{rcu_try_flip_waitack_needed()} > that would have been quite difficult to test or debug, as > - shown by the following patch~\cite{PaulEMcKenney2008commit:ae66be9b71b1}. > + shown by the following patch~\cite{PaulEMcKenney2008commit:d7c0651390b6}. > > \begin{VerbatimU} > - if ((curr - snap) > 2 || (snap & 0x1) == 0)