On Tue, Feb 07, 2023 at 09:19:09AM +0900, Akira Yokosawa wrote:
> On Mon, 6 Feb 2023 17:55:15 -0300, Leonardo Bras wrote:
> > `make -C CodeSamples/ check` currently fails on Gitlab-CI.
> >
> > Failure happen on sched_setaffinity:
> > sched_setaffinity: Invalid argument
> >
> > Further debuging, it's possible to notice that some tests are trying to set
> > the cpu affinity in CPUs 0 and 1, so at least 2 cpus are needed for the
> > test to run properly.
> >
> > Current (default) saas-linux-small-amd64 instances used for testing on
> > Gitlab-CI only offer a single CPU, which is not enough.
> >
> > For the test_codesamples pre-test, change the instance type to
> > saas-linux-medium-amd64 so the tests can run properly.
> >
> > Fixes: 9217963c ("utilities/gitlab-ci.yml: Add 'make check' on
> > test_codesamples")
> > Signed-off-by: Leonardo Bras <leobras.c@xxxxxxxxx>
>
> Hi,
>
> I see that this change worked at:
>
> https://gitlab.com/linux-kernel/perfbook/-/jobs/3723917786
>
> So FWIW,
>
> Reviewed-by: Akira Yokosawa <akiyks@xxxxxxxxx>
Queued and pushed, thank you both!
> I don't have a list of minimum CPU count for programs under
> CodeSamples/, but I guess there are a few which need more than
> two CPUs.
>
> You might need to add conditionals in Makefile to exclude those
> tests depending on available CPU count.
In addition, some of the tests may need special command-line arguments.
For example, most of the tests that take "--smoketest" probably want to
use that argument for "make check".
One thought is to take this one directory at a time. Any better ideas?
Thanx, Paul
> Thanks, Akira
>
> > ---
> > utilities/gitlab-ci.yml | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/utilities/gitlab-ci.yml b/utilities/gitlab-ci.yml
> > index 9545029e..42eda60f 100644
> > --- a/utilities/gitlab-ci.yml
> > +++ b/utilities/gitlab-ci.yml
> > @@ -5,6 +5,7 @@ stages:
> > - build
> >
> > test_codesamples:
> > + tags: [ saas-linux-medium-amd64 ]
> > stage: test
> >
> > before_script:
