On Thu, Jan 26, 2023 at 09:23:26AM +0900, Akira Yokosawa wrote:
> The default of "pdflatex" has never worked as expected.
> When these scripts run under Makefile's control, they are
> given "LATEX=pdflatex" by default, and work just fine.
>
> When directly invoked from command line:
>
> $ sh utilities/runfirstlatex.sh perfbook
>
> , it runs with LATEX="" and ends up in one of various errors.
>
> Fix this by using the right pattern of ":=".
>
> Fixes: 241d5350b162 ("run{first}latex.sh: Use variable for 'pdflatex' command")
> Signed-off-by: Akira Yokosawa <akiyks@xxxxxxxxx>
Queued and pushed, thank you!
Thanx, Paul
> ---
> utilities/runfirstlatex.sh | 2 +-
> utilities/runlatex.sh | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/utilities/runfirstlatex.sh b/utilities/runfirstlatex.sh
> index b92895f332ca..f12f14886747 100644
> --- a/utilities/runfirstlatex.sh
> +++ b/utilities/runfirstlatex.sh
> @@ -67,7 +67,7 @@ fi
>
> basename=`echo $1 | sed -e 's/\.tex$//'`
>
> -: ${LATEX:-pdflatex}
> +: ${LATEX:=pdflatex}
>
> echo "$LATEX 1 for $basename.pdf"
> $LATEX $LATEX_OPT $basename > /dev/null 2>&1 < /dev/null
> diff --git a/utilities/runlatex.sh b/utilities/runlatex.sh
> index d4c9baf8740a..e23bc87ba978 100644
> --- a/utilities/runlatex.sh
> +++ b/utilities/runlatex.sh
> @@ -29,7 +29,7 @@
> # Authors: Paul E. McKenney <paulmck@xxxxxxxxxx>
> # Akira Yokosawa <akiyks@xxxxxxxxx>
>
> -: ${LATEX:-pdflatex}
> +: ${LATEX:=pdflatex}
>
> diff_warning () {
> if diff -q $basename-warning.log $basename-warning-prev.log >/dev/null
>
> base-commit: 685184dff46ffdec02b7402a36b06359cb085f29
> --
> 2.25.1
>
