[PATCH -perfbook v2] memorder: fix a line number reference error

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Section 15.2.3 says,

  "Listing 15.10 shows how to make this work reliably on pre-v4.15
   Linux kernels running on DEC Alpha, by replacing line 19's
   READ_ONCE() with lockless_dereference()."

However, the READ_ONCE() is actually on line 18 of Listing 15.9.

Fix the reference and clarify the READ_ONCE() is in Listing 15.9.

Reported-by: Zhouyi Zhou <zhouzhouyi@xxxxxxxxx>
Signed-off-by: Akira Yokosawa <akiyks@xxxxxxxxx>
---
v1 (from Zhouyi) -> v2

 - Reference line 18 of Listing 15.9.
 - Adjust wording around the fixed reference.
 - Zhouyi's Reported-by.

Zhouyi, how does this look to you?

Thanks, Akira
--
 memorder/memorder.tex | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/memorder/memorder.tex b/memorder/memorder.tex
index c350758d61cb..28319bfba16b 100644
--- a/memorder/memorder.tex
+++ b/memorder/memorder.tex
@@ -1274,13 +1274,14 @@ exists (1:r2=x0 /\ 1:r3=1)
 \label{lst:memorder:Enforced Ordering of Message-Passing Address-Dependency Litmus Test (Before v4.15)}
 \end{listing}
 
-\begin{fcvref}[ln:memorder:Enforced Ordering of Message-Passing Address-Dependency Litmus Test (Before v4.15)]
+\begin{fcvref}[ln:formal:C-MP+o-wmb-o+o-addr-o:whole]
 \Cref{lst:memorder:Enforced Ordering of Message-Passing Address-Dependency Litmus Test (Before v4.15)}
 % \path{C-MP+o-wmb-o+ld-addr-o.litmus} available at commit bc4b1c3f3b35
 % ("styleguide: Loosen restriction on comment in litmus test")
 shows how to make this work reliably on pre-v4.15 Linux kernels running on
-DEC Alpha, by replacing \clnref{read}'s \co{READ_ONCE()} with
-\apikh{lockless_dereference()},\footnote{
+DEC Alpha, by replacing \co{READ_ONCE()} on \clnref{P1:x1} of
+\cref{lst:memorder:Message-Passing Address-Dependency Litmus Test (No Ordering Before v4.15)}
+with \apikh{lockless_dereference()},\footnote{
 	Note that \co{lockless_dereference()} is not needed on v4.15 and
 	later, and therefore is not available in these later Linux kernels.
 	Nor is it needed in versions of this book containing this sentence.}

base-commit: c2b75b99a151008c6b59bddcabb9e44e744f3678
-- 
2.25.1





[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux