On Mon, Aug 15, 2022 at 06:42:22AM -0400, Elad Lahav wrote: > On 2022-08-15 06:37, Elad Lahav wrote: > > + cat api-pthreads/api-$(os_compat).h >> api.h > > I didn't want to go overboard here, so it's just the minimum required for > having a single per-OS header with specific definitions. I am good with that, thank you! > > +#ifndef CLOCK_MONOTONIC_RAW > > +#define CLOCK_MONOTONIC_RAW CLOCK_MONOTONIC > > +#endif > > This one wasn't moved to the per-OS header because of the order in which > headers are included, which I didn't want to fiddle with. That is fine, especially given that there are other POSIX OSes, including old versions of Linux, that do not have CLOCK_MONOTONIC_RAW. > That said, would you be open to changing the ARM64 get_timestamp() to a > simple read of the hardware clock? It is architecturally-defined. Sounds good to me! Your patch looks good and works on my system. One nit, but an important one: The new api-pthreads/api-qnx.h file should have your copyright notice rather than mine, given that you created the file. Does something like this work for you? * Copyright (c) 2021 Elad Lahav, BlackBerry. Thanx, Paul
