On Sun, Jan 30, 2022 at 06:38:37PM +0900, Akira Yokosawa wrote:
> Commit xxxxxxxxxxxx ("Makefile: Fix issues WRT parallel runs of
> pdflatex") changed dependency around autodate.tex so that it
> depends only on files in the Git repository.
>
> However, this change causes autodate.sh to see untracked temporary
> intermediate files from concurrent conversion of figures.
> It ends up adding the "(m)" maker in autodate.tex even when there is
> no untracked file in the beginning.
>
> Fix the regression by partially reverting xxxxxxxxxxxx and restoring
> dependencies of autodate.tex on converted PDF and .fcv files.
>
> Note: This regression was caught by parallel-latex-regress.sh
> when Paul ran it under clean Git repository.
>
> Fixes: xxxxxxxxxxxx ("Makefile: Fix issues WRT parallel runs of pdflatex")
> Reported-by: Paul E. McKenney <paulmck@xxxxxxxxxx>
> Signed-off-by: Akira Yokosawa <akiyks@xxxxxxxxx>
Much better! Queued with SHA-1 applied and pushed, thank you!!!
At least this way we tested the test. ;-)
Thanx, Paul
> ---
> Paul,
>
> I can merge this with 2/4, but I'd rather keep this partial revert
> as an example of regression found by the script.
>
> If you push this series to master, please amend the commit ids
> in the change log.
>
> Thanks, Akira
> --
> Makefile | 10 ++++------
> 1 file changed, 4 insertions(+), 6 deletions(-)
>
> diff --git a/Makefile b/Makefile
> index ee1880ff..e09ba32d 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -228,14 +228,12 @@ ifeq ($(NEWTXTEXT),)
> endif
> sh utilities/runfirstlatex.sh $(basename $@)
>
> -autodate.tex: $(LATEXSOURCES) $(BIBSOURCES) $(SOURCES_OF_SNIPPET) \
> - $(LST_SOURCES) $(FIGSOURCES) $(DOTSOURCES) $(EPSORIGIN) \
> - $(SVGSOURCES) $(GITREFSTAGS) \
> - utilities/autodate.sh
> +autodate.tex: $(LATEXSOURCES) $(BIBSOURCES) $(LST_SOURCES) \
> + $(PDFTARGETS_OF_EPS) $(PDFTARGETS_OF_SVG) $(FCVSNIPPETS) $(FCVSNIPPETS_VIA_LTMS) \
> + $(GITREFSTAGS) utilities/autodate.sh
> sh utilities/autodate.sh
>
> -perfbook_flat.tex: autodate.tex $(PDFTARGETS_OF_EPS) $(PDFTARGETS_OF_SVG) \
> - $(FCVSNIPPETS) $(FCVSNIPPETS_VIA_LTMS)
> +perfbook_flat.tex: autodate.tex
> ifndef LATEXPAND
> $(error --> $@: latexpand not found. Please install it)
> endif
> --
> 2.17.1
>
>
