Re: [PATCH -perfbook 04/11] Add \ignorespaces command to \IfEbookSize and \IfSansSerif

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Aug 18, 2021 at 08:31:05AM +0900, Akira Yokosawa wrote:
> On Tue, 17 Aug 2021 11:29:51 -0700, Paul E. McKenney wrote:
> > On Tue, Aug 17, 2021 at 07:21:27PM +0900, Akira Yokosawa wrote:
> >> Using \IfEbookSize or \IfSansSerif macro in the middle of a paragraph
> >> can cause extra white spaces around it.
> >> Fix this by adding the \ignorespaces command in their definitions.
> >>
> >> Also update the conditional text in styleguide.
> >>
> >> As the other conditional macros aren't used in this manner, they are
> >> not modified for the moment.
> >>
> >> Signed-off-by: Akira Yokosawa <akiyks@xxxxxxxxx>
> >> ---
> >>  appendix/styleguide/styleguide.tex | 5 +++--
> >>  perfbook-lt.tex                    | 6 ++++--
> >>  2 files changed, 7 insertions(+), 4 deletions(-)
> >>
> >> diff --git a/appendix/styleguide/styleguide.tex b/appendix/styleguide/styleguide.tex
> >> index 9bb9683f..24e891a3 100644
> >> --- a/appendix/styleguide/styleguide.tex
> >> +++ b/appendix/styleguide/styleguide.tex
> >> @@ -1013,8 +1013,9 @@ namely \qco{$-$}.\footnote{This rule assumes that math mode uses the
> >>    same upright glyph as text mode.
> >>    Our default font choice meets the assumption.
> >>  \IfSansSerif{
> >> -  One of the experimental targets ``1csf'' \emph{does} use a differnt font
> >> -  for math mode figures as of October 2017.}{}
> >> +  Experimental targets with sans-serif fonts such as
> >> +  ``1csf'' and ``ebsf'' \emph{do} use a differnt font
> > 
> > I did s/differnt/different/ here.  This looks like the sort of typo
> > that I would make!  ;-)
> 
> So, I made the typo way back in 2017.
> A typo in a footnote in Style Guide is unlikely to be caught. ;-)

To your point, I most certainly did not catch it!  ;-)

But yes, I should have checked for the typo in the old line as well
as the new line.

							Thanx, Paul

> >> +  for math mode figures as of August 2021.}{}
> >>  }
> >>  For example,
> >>  
> >> diff --git a/perfbook-lt.tex b/perfbook-lt.tex
> >> index 62959e04..b1c4f780 100644
> >> --- a/perfbook-lt.tex
> >> +++ b/perfbook-lt.tex
> >> @@ -117,13 +117,15 @@
> >>  \newcommand{\IfHardCover}[2]{\ifthenelse{\boolean{hardcover}}{#1}{#2}}
> >>  \newboolean{ebooksize}
> >>  \setboolean{ebooksize}{false}
> >> -\newcommand{\IfEbookSize}[2]{\ifthenelse{\boolean{ebooksize}}{#1}{#2}}
> >> +\newcommand{\IfEbookSize}[2]{\ifthenelse{\boolean{ebooksize}}%
> >> +  {\ignorespaces#1\ignorespaces}{\ignorespaces#2\ignorespaces}}
> >>  \newboolean{afourpaper}
> >>  \setboolean{afourpaper}{false}
> >>  \newcommand{\IfAfourPaper}[2]{\ifthenelse{\boolean{afourpaper}}{#1}{#2}}
> >>  \newboolean{sansserif}
> >>  \setboolean{sansserif}{false}
> >> -\newcommand{\IfSansSerif}[2]{\ifthenelse{\boolean{sansserif}}{#1}{#2}}
> >> +\newcommand{\IfSansSerif}[2]{\ifthenelse{\boolean{sansserif}}%
> >> +  {\ignorespaces#1\ignorespaces}{\ignorespaces#2\ignorespaces}}
> >>  \newboolean{lmttforcode}
> >>  \setboolean{lmttforcode}{true}
> >>  \newcommand{\IfLmttForCode}[2]{\ifthenelse{\boolean{lmttforcode}}{#1}{#2}}
> >> -- 
> >> 2.17.1
> >>
> >>



[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux