On Wed, May 19, 2021 at 12:12:44AM +0800, Zhouyi Zhou wrote: > hi, Paul > > In appendix B.7: "Lines 3 and 4 simply add one to > the global free-running rcu_gp_ctr variable" > > I looked up webster online dictionary > https://www.merriam-webster.com/dictionary/add%20to > it says "Definition of add to" is "to make (something) larger, > better, or greater" > meanwhile rcu_gp_ctr is not changed in this statement. In this case, "add" as in "addition" as in arithmetic, similar to the C-language "+=" operator. But... > My native language is not English, I try to search the web > for an example, and I think if replace 'to' with 'and' maybe a > better choice. > > Maybe my proposal is not necessary. > > Thanks for your time. ...this one falls into the "correct but confusing" bucket. Would "add the value one to the global free-running rcu_gp_ctr variable" work better for you? Thanx, Paul > Best Wishes > Zhouyi > --- > appendix/toyrcu/toyrcu.tex | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/appendix/toyrcu/toyrcu.tex b/appendix/toyrcu/toyrcu.tex > index be77c045..dd759ba7 100644 > --- a/appendix/toyrcu/toyrcu.tex > +++ b/appendix/toyrcu/toyrcu.tex > @@ -976,7 +976,7 @@ The resulting \co{rcu_read_lock()} implementation is extremely > straightforward. > \begin{fcvref}[ln:defer:rcu:read_lock_unlock:lock] > \Clnref{gp1,gp2} simply > -add one to the global free-running \co{rcu_gp_ctr} > +add one and the global free-running \co{rcu_gp_ctr} > variable and stores the resulting odd-numbered value into the > \co{rcu_reader_gp} per-thread variable. > \Clnref{mb} executes a memory barrier to prevent the content of the > -- > 2.25.1 >
