On Wed, Apr 28, 2021 at 08:58:57AM +0900, Akira Yokosawa wrote: > On Tue, 27 Apr 2021 15:52:42 -0700, Paul E. McKenney wrote: > > On Wed, Apr 28, 2021 at 07:32:25AM +0900, Akira Yokosawa wrote: > >> On Tue, 27 Apr 2021 08:51:26 -0700, Paul E. McKenney wrote: > >>> On Wed, Apr 28, 2021 at 12:18:56AM +0900, Akira Yokosawa wrote: > >>>> Hi Paul, > >>>> > >>>> This patch set adds a set of scripts to check proper annotation > >>>> of periods to distinguish single and double spacing. > >>>> > >>>> Patch 1/9 adds a couple of annotations in-development version of > >>>> the script had caught. > >>>> Patches 2/9--5/9 add and improve the set of scripts. > >>>> They are kept separate patches to show the history. > >>>> Patches 6/9--9/9 are fixes in LaTeX sources to satisfy the script. > >>>> There are quite a few sentences which end in the middle of > >>>> input lines. > >>>> > >>>> After Patch 9/9 is applied, "make periodcheck" will be clean. > >>>> > >>>> I'm not saying the perl script is complete. > >>>> There can still be false negatives I'm not aware of. > >>>> False positives can happen when you add new contents. > >>> > >>> Queued and pushed, thank you! > >>> > >>> Would it make sense at some point to have "make periodcheck" happen > >>> automatically during a normal build to catch addition of issues with > >>> new content? > >>> > >>> Thanx, Paul > >> > >> Like this? > >> Note that positive periodcheck doesn't cause a make error. > >> It can be promoted to a real error later when we feel confident of > >> the script. > >> > >> "make 2c" (or any explicit target) doesn't run the script. > > > > This does work! > > > > But I feel compelled to expose the ancient nature of my Makefile > > knowledge and ask why not this single change? > > > > all: $(targ) periodcheck > > You might miss the output from periodcheck if you do > > "make -jN" > > , without the dependency of "periodcheck: $(targ)". Excellent point, thank you! Thanx, Paul > Thanks, Akira > > > > > Thanx, Paul > > > >> Thanks, Akira > >> > >> --------8<-------------------------- > >> From: Akira Yokosawa <akiyks@xxxxxxxxx> > >> Date: Wed, 28 Apr 2021 07:26:05 +0900 > >> Subject: [PATCH] Auto run periodcheck on 'make' > >> > >> Run periodcheck on "make" and "make all". > >> Now they are the same as "make periodcheck". > >> "make periodcheck" builds your default target before the check. > >> > >> Suggested-by: Paul E. McKenney <paulmck@xxxxxxxxxx> > >> Signed-off-by: Akira Yokosawa <akiyks@xxxxxxxxx> > >> --- > >> Makefile | 4 ++-- > >> 1 file changed, 2 insertions(+), 2 deletions(-) > >> > >> diff --git a/Makefile b/Makefile > >> index ea264dc5..792fa285 100644 > >> --- a/Makefile > >> +++ b/Makefile > >> @@ -194,7 +194,7 @@ BASE_DEPENDS := perfbook.tex $(foreach v,tcb 1c msns mss mstx msr msn msnt sf nq > >> .PHONY: help-experimental help-prefixed > >> .PHONY: paper-clean periodcheck > >> > >> -all: $(targ) > >> +all: periodcheck > >> > >> ifeq ($(MAKECMDGOALS),clean) > >> else ifeq ($(MAKECMDGOALS),distclean) > >> @@ -611,7 +611,7 @@ ls-unused: > >> neatfreak: distclean > >> find . -name '*.pdf' | xargs rm -f > >> > >> -periodcheck: > >> +periodcheck: $(targ) > >> utilities/periodcheck.sh > >> > >> .SECONDEXPANSION: > >> -- > >> 2.17.1 > >> > >> > >>
