(Dropped CC: Daniel) On Sun, 3 Jan 2021 20:12:00 -0800, Paul E. McKenney wrote: > On Mon, Jan 04, 2021 at 12:56:25PM +0900, Akira Yokosawa wrote: >> On Sun, 3 Jan 2021 16:32:07 -0800, Paul E. McKenney wrote: >>> On Sun, Jan 03, 2021 at 10:24:29AM -0800, Paul E. McKenney wrote: >>>> On Sun, Jan 03, 2021 at 01:12:40PM +0900, Akira Yokosawa wrote: >> [...] >>>>> >>>>> Hi Paul, >>>>> >>>>> Off topic, but smp_read_barrier_depends() as a kernel API >>>>> has been removed since Linux v5.9 [1]. >>>>> Now READ_ONCE() for Alpha uses mb() [2]. >>>>> >>>>> You might want to reflect these changes in perfbook before the >>>>> release of the Second Edition. >>>>> >>>>> [1]: merge commit https://git.kernel.org/linus/145ff1ec090d >>>>> ("Merge tag 'arm64-upstream' of git://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux") >>>>> [2]: commit https://git.kernel.org/linus/d64628588515 >>>>> ("alpha: Override READ_ONCE() with barriered implementation") >>>> >>>> Good catch, thank you! We will of course need to retain mention of >>>> smp_read_barrier_depends() given that people will be using pre-v4.15 >>>> (to say nothing of pre-v5.9) kernels for some time, but the main code >>>> does need to reflect the current state of the Linux kernel. >>>> >>>> Perhaps in the third edition we should drop any and all references >>>> to DEC Alpha. It is no longer in any way special, at least from the >>>> perspective of core kernel code. ;-) >>>> >>>> I suppose that the counter-argument is that non-Linux-kernel code might >>>> still need to pay attention, so maybe DEC Alpha needs to stay until such >>>> time as C/C++ handle address and data dependencies. Worth some thought. >>> >>> In the meantime, how about like this? >> Looks reasonable to me. >> There is a footnote which now looks redundant. >> Please find a patch below (on top your change) to remove it. >> >> With my patch (or similar) applied, >> >> Reviewed-by: Akira Yokosawa <akiyks@xxxxxxxxx> > > Applied and pushed both, thank you! Paul, Could you please amend commit 3cccf2e94038 ("Cope with GhostScript 9.53.0 or later") to remove extra header lines: From d48155e896265c1a26985fe26f9bf8c5fbcfd22e Mon Sep 17 00:00:00 2001 From: Akira Yokosawa <akiyks@xxxxxxxxx> Date: Mon, 4 Jan 2021 07:58:18 +0900 Subject: [PATCH v2 -perfbook] Makefile: Cope with GhostScript 9.53.0 or later MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit ? Looks like git-am does not automatically remove them when "MIME-Version:" is in the header part. Thanks, Akira > > Thanx, Paul > >> Thanks, Akira >> >>> >>> Thanx, Paul [...]
