On Tue, Nov 6, 2018 at 3:51 AM Paul E. McKenney <paulmck@xxxxxxxxxxxxx> wrote: > > On Sun, Nov 04, 2018 at 09:04:28PM +0900, Akira Yokosawa wrote: > > On 2018/11/04 19:18:37 +0800, Junchang Wang wrote: > > > Hi Paul and Akira, > > > > > > I have read through the first half of Chapter memorder, and here is correction > > > for a few typos. Please take a look. > > > > > > For the first patch, the last clause I modified still looks confusion to me. > > > Currently the clause is "though only if both \co{r1} and \co{r3} both end up > > > containing the address of \co{x}"; however, my understanding is that prior load > > > or store would also be ordered before the store on line 16, __only if r1 ends up > > > containing the address of x__. That is, it is not necessary to involve r2/r3. Is > > > my understanding correct? Or did I miss anything about this in the book? > > > > Going back to commit 43236beadb19 ("memorder: Expand on cumulativity and > > {other,} multicopy atomicity"), this paragraph discussed Listing 14.17 > > at the time (WWC Litmus Test With Release), which is a different litmus > > test than the current Listing 15.17 (WRC Litmus Test With Release). > > Still line 32 of then Listing 14.17 was an "exists" clause. > > No wonder you can't figure out what is discussed there. > > > > Paul, can you look into this? > > Indeed, this was quite the mess! Hopefully now fixed. ;-) > Great! Thanks to both of you :-). Cheers, --Junchang > Thanx, Paul > > > Thanks, Akira > > > > > > > > > > > Thanks, > > > --Junchang > > > > > > Junchang Wang (2): > > > memorder: fix typo > > > memorybarriercum.svg: fix typo > > > > > > memorder/memorder.tex | 8 ++++---- > > > memorder/memorybarriercum.svg | 2 +- > > > 2 files changed, 5 insertions(+), 5 deletions(-) > > > > > >