On Sat, Oct 13, 2018 at 11:52:50PM +0900, Akira Yokosawa wrote: > Hi Paul, > > count_lim_sig.c was a hard one to review for me regarding the usage > of READ_ONCE()/WRITE_ONCE(). Patch #5 is my attempt to add several > of them. There might be other combination of racy accesses. > > Patches #1--#4 are trivial ones. > > Patch #6 is the result of quick review of your recent addition to > toolsoftrade. I'm not sure you like the addition of comments > "/* BUGGY!!! */" to Lisitngs which look irrelevant to their > captions. > > Patches #5 and #6 are more likely to need your close look. It looks good from what I can see, though your patch 6/6 should limit your confidence in this. ;-) I folded your later 7/6 into 4/6. Queued and pushed, thank you!!! Thanx, Paul > Thanks, Akira > -- > Akira Yokosawa (6): > count: Employ new scheme for snippet of count_lim_app > count: Fix uses of READ/WRITE_ONCE() in count_lim_app > count: Employ new scheme for snippet of count_lim_atomic > count: Employ new scheme for snippet of count_lim_sig > count: READ/WRITE_ONCE() tweaks for count_lim_sig > toolsoftrade: Proofread newly added sections > > CodeSamples/count/count_lim_app.c | 17 +- > CodeSamples/count/count_lim_atomic.c | 209 ++++---- > CodeSamples/count/count_lim_sig.c | 159 ++++--- > count/count.tex | 892 ++++++++++------------------------- > toolsoftrade/toolsoftrade.tex | 44 +- > 5 files changed, 494 insertions(+), 827 deletions(-) > > -- > 2.7.4 >