On Tue, Jul 17, 2018 at 12:42:57AM +0900, Akira Yokosawa wrote:
> Hi Paul,
>
> See inline comments below for a few nits and suggestions.
I fixed the perror() calls straightforwardly, thank you!
Queued and pushed with both your and Elad's Reported-by.
> On 2018/07/14 16:33:13 -0700, Paul E. McKenney wrote:
> > On Sat, Jul 14, 2018 at 08:59:48AM -0400, Elad Lahav wrote:
[ . . . ]
> I see you have already updated most of the code samples under CodeSamples/,
> but let me suggest an alternative way not to increase line counts
> (or even to decrease line counts).
>
> "pthread_create(3)" man page gives you an example code.
>
> First, two helpers are defined as follows:
>
> #define handle_error_en(en, msg) \
> do { errno = en; perror(msg); exit(EXIT_FAILURE); } while (0)
>
> #define handle_error(msg) \
> do { perror(msg); exit(EXIT_FAILURE); } while (0)
>
> Then, one of the call sites looks as follows:
>
> s = pthread_create(&tinfo[tnum].thread_id, &attr,
> &thread_start, &tinfo[tnum]);
> if (s != 0)
> handle_error_en(s, "pthread_create");
>
> If we employ this pattern, one of the hunks in your patch will look like:
>
> - if (pthread_mutex_lock(pmlp) != 0) {
> - perror("lock_reader:pthread_mutex_lock");
> - exit(-1);
> - }
> + if ((en = pthread_mutex_lock(pmlp)) != 0)
> + handle_error_en(en, "lock_reader:pthread_mutex_lock");
>
> Thoughts?
>
> I think these error cases are not our main topic, and to hide the
> details inside helpers sounds reasonable.
Does it make sense to pull the "if" into the handle_error_en() macro
as well, perhaps like this?
#define handle_error_en(en, msg) \
do { if (!en) break; errno = en; perror(msg); exit(EXIT_FAILURE); } while (0)
s = pthread_create(&tinfo[tnum].thread_id, &attr,
&thread_start, &tinfo[tnum]);
handle_error_en(s, "pthread_create");
> Also, wouldn't it be a good idea to employ auto-numbering scheme as
> mentioned in Section D.3.1.1 of Style Guide when updating code snippets?
> This update will involve a lot of renumbering of line numbers otherwise.
>
> If you feel OK with this approach, I can prepare a patch series
> on behalf of you. (Can take a little while, though.)
This approach involves labeling lines that are referred to in the text?
If those labels could be introduced as comments in the original code,
that could be really nice!
Thanx, Paul
--
To unsubscribe from this list: send the line "unsubscribe perfbook" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
