Hi Akira,
On Sat, Jul 15, 2017 at 1:20 PM, Akira Yokosawa <akiyks@xxxxxxxxx> wrote:
> Hi Jason,
>
> On 2017/07/15 11:51:46 +0800, Junchang Wang wrote:
>> Hi Paul,
>>
>> I have read through Chapter Advance Synchronization, and following are two
>> typos. Please take a look. Thanks for this excellent book!
>>
>> Signed-off-by: Junchang Wang <junchangwang@xxxxxxxxx>
>> ---
>> advsync/memorybarriers.tex | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/advsync/memorybarriers.tex b/advsync/memorybarriers.tex
>> index c9c975c..009dc6e 100644
>> --- a/advsync/memorybarriers.tex
>> +++ b/advsync/memorybarriers.tex
>> @@ -950,7 +950,7 @@ thereby forcing the required ordering on all platforms.
>> \label{fig:advsync:S Address-Dependency Litmus Test}
>> \end{figure}
>>
>> -But suppose that the dependent operation is a write rather than
>> +But what happens if the dependent operation is a write rather than
>> a read, for example, in the \emph{S}
>> litmus test~\cite{JadeAlglave2011ppcmem} shown in
>> Figure~\ref{fig:advsync:S Address-Dependency Litmus Test}?
>> @@ -2511,7 +2511,7 @@ Failure to follow this rule can have serious side effects:
>> In theory, yes, you could load an integer, perhaps to use
>> it as an array index.
>> In practice, the compiler knows too much about integers,
>> - and thus has way too many opportunities to break your
>> + and thus has too many opportunities to break your
>
> This "way" is an adverb for emphasizing. It might sound colloquial
> but it's the tone in perfbook. So I would NAK this hunk.
>
Thanks a lot for the explanation!
> Also, the format of this message would result in your greetings being
> included in the commit log if it were applied as is.
> It would be better if you put the greetings between "---" and diff stat.
>
> For the 1st hunk, I would suggest a commit title something like:
>
> advsync: Rephrase question as such
>
> Can you try a respin with the following tag?
>
Sure. I can resend a new patch soon.
Thanks,
--Jason
> Suggested-by: Akira Yokosawa <akiyks@xxxxxxxxx>
>
> Thanks, Akira
>
>> dependency chain.
>> \end{enumerate}
>>
>>
>
--
To unsubscribe from this list: send the line "unsubscribe perfbook" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
