On Thu, Jul 13, 2017 at 11:03:43AM -0700, Paul E. McKenney wrote: > On Thu, Jul 13, 2017 at 12:07:18AM +0900, Akira Yokosawa wrote: > > >From de45acd5a73354cbe03abaf3130177687c77e4cb Mon Sep 17 00:00:00 2001 > > From: Akira Yokosawa <akiyks@xxxxxxxxx> > > Date: Wed, 12 Jul 2017 23:45:17 +0900 > > Subject: [PATCH 0/6] advsync: Misc. fixes around litmus tests > > > > Hi Paul, > > > > This patch set tries to cleanup recently updated material in advsync. > > > > Patches 1 to 3 are fixes of litmus tests under CodeSamples/advsync/herd > > and their corresponding snippets in memorybarriers.tex. > > > > Patch 4 is trivial fixes. > > > > Patch 5 is my attempt for the sentence to make sense. > > > > Patch 6 updates the usage of x0 and x1 in the tables of Store-Buffering > > Sequence of Events. I stopped short of using READ_ONCE() and WRITE_ONCE() > > in the "Instruction" columns. The change seems unnecessary for me. > > I think we can assume a reader of this section can easily translate > > READ_ONCE() and WRITE_ONCE() to simple assignments in his/her mind. > > Also, you are calling x0 and x1 as if they are variables in the text. > > But I don't think the current way of description is ambiguous. > > > > So, Patches 1 to 4 should be all right. You might feel otherwise to > > Patches 5 and 6. > > Good catches, thank you!!! > > The only think I didn't take was the addition of indirection to the > variables in the tables. The litmus tests have the indirection on > the function parameters, and omit it in the exists clause. So there > is potential for confusion either way. So I came down on the side of > the shortest way, that is, omitting the indirection. > > And yes, my original tables were inconsistent! ;-) > > I also took your 7/6 patch, and thank you again. And kernel.org is having some issues, so I pushed to my github perfbook repo. Hopefully kernel.org will be feeling better later... Thanx, Paul > > Thoughts? > > > > Thanks, Akira > > -- > > Akira Yokosawa (6): > > advsync: Fix typo of litmus name > > advsync: Fix typos in load-buffering litmus tests > > advsync: Fix remaining typo in exists condition > > advsync: Trivial typo fixes > > advsync: Fix grammatical error > > advsync: Adjust value expressions in Tables 14.1 and 14.2 > > > > CodeSamples/advsync/herd/C-LB+o-o+o-o.litmus | 2 +- > > CodeSamples/advsync/herd/C-LB+o-r+a-o.litmus | 4 +- > > .../advsync/herd/C-MP+o-wmb-o+o-rmb-o.litmus | 2 +- > > advsync/memorybarriers.tex | 103 ++++++++++----------- > > 4 files changed, 55 insertions(+), 56 deletions(-) > > > > -- > > 2.7.4 > > -- To unsubscribe from this list: send the line "unsubscribe perfbook" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
