Hi,
I have a few comments regarding this patch.
On 2016/09/21 11:44:40 +0900, SeongJae Park wrote:
> Signed-off-by: SeongJae Park <sj38.park@xxxxxxxxx>
> ---
> formal/dyntickrcu.tex | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/formal/dyntickrcu.tex b/formal/dyntickrcu.tex
> index 5ede587..1d3e155 100644
> --- a/formal/dyntickrcu.tex
> +++ b/formal/dyntickrcu.tex
> @@ -213,7 +213,7 @@ Line~3 fetches the current CPU's number, while lines~5 and~6
> increment the \co{rcu_update_flag} nesting counter if it
> is already non-zero.
> Lines~7-9 check to see whether we are the outermost level of
> -interrupt, and, if so, whether \co{dynticks_progress_counter}
> +interrupt, and, if so, \co{dynticks_progress_counter}
> needs to be incremented.
> If so, line~10 increments \co{dynticks_progress_counter},
> line~11 executes a memory barrier, and line~12 increments
I think this change is unnecessary. The original sentence makes
sense for me.
> @@ -887,9 +887,9 @@ is even.
> Upon failure, \co{spin} writes out a
> ``trail'' file
> (\path{dyntickRCU-base-sl-busted.spin.trail})
> -file, which records the sequence of states that lead to the failure.
> +, which records the sequence of states that lead to the failure.
> Use the {\tt spin -t -p -g -l dyntickRCU-base-sl-busted.spin}
> -command to cause \co{spin} to retrace this sequence of state,
> +command to cause \co{spin} to retrace this sequence of states,
> printing the statements executed and the values of variables
> (\path{dyntickRCU-base-sl-busted.spin.trail.txt}).
> Note that the line numbers do not match the listing above due to
>
Well, if you put the "," at the beginning of the line, there would be
an extra space (or even a line break) between the ")" and the ",".
A better hunk would be as the following;
> @@ -886,10 +886,10 @@ results in failure, as line~23 is checking that the wrong
> is even.
> Upon failure, \co{spin} writes out a
> ``trail'' file
> -(\path{dyntickRCU-base-sl-busted.spin.trail})
> -file, which records the sequence of states that lead to the failure.
> +(\path{dyntickRCU-base-sl-busted.spin.trail}),
> +which records the sequence of states that lead to the failure.
> Use the {\tt spin -t -p -g -l dyntickRCU-base-sl-busted.spin}
> -command to cause \co{spin} to retrace this sequence of state,
> +command to cause \co{spin} to retrace this sequence of states,
> printing the statements executed and the values of variables
> (\path{dyntickRCU-base-sl-busted.spin.trail.txt}).
> Note that the line numbers do not match the listing above due to
Thanks, Akira
--
To unsubscribe from this list: send the line "unsubscribe perfbook" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
