Re: [PATCH 4/6] advsync: fix wrong code example

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



If you would like, I don't mind you adding

Suggested-by: Akira Yokosawa <akiysw@xxxxxxxxx>

to the commit log.

-- 
 Akira Yokosawa <akiysw@xxxxxxxxx>

2016-04-02 11:52 GMT+09:00 SeongJae Park <sj38.park@xxxxxxxxx>:
> Hi,
>
>
> On Sat, 2 Apr 2016, Yokosawa Akira wrote:
>
>> Sorry, I missed cc: to the list. Reposting...
>>
>> --
>> Hi,
>>
>> 2016-04-02 9:28 GMT+09:00 SeongJae Park <sj38.park@xxxxxxxxx>:
>>>
>>> The code means `Y = *(A + 4)` but it is written as `Y = *A`. This commit
>>> fixes the typo.
>>>
>>> Signed-off-by: SeongJae Park <sj38.park@xxxxxxxxx>
>>> ---
>>>  advsync/memorybarriers.tex | 2 +-
>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/advsync/memorybarriers.tex b/advsync/memorybarriers.tex
>>> index ee9312d..b1f49d3 100644
>>> --- a/advsync/memorybarriers.tex
>>> +++ b/advsync/memorybarriers.tex
>>> @@ -1364,7 +1364,7 @@ Y = LOAD *(A + 4); X = LOAD *A;
>>>  \begin{minipage}[t]{\columnwidth}
>>>  \scriptsize
>>>  \begin{verbatim}
>>> -*A = X; Y = *A;
>>> +*A = X; Y = *(A + 4);
>>
>>
>> I think
>>
>> + *A = X; *(A + 4) = Y;
>>
>> is what meets the possible combination given below.
>>
>> STORE *A = X; STORE *(A + 4) = Y;
>> STORE *(A + 4) = Y; STORE *A = X;
>> STORE {*A, *(A + 4) } = {X, Y};
>
>
> Oops, you're right.  Thank you for let me know.  I will upload modified
> version patch soon.
>
>
> Thanks,
> SeongJae Park
>
>
>>
>> Regards,
>>
>>
>> --
>> Akira Yokosawa <akiysw@xxxxxxxxx>
>>
>>
>>>  \end{verbatim}
>>>  \end{minipage}
>>>  \vspace{5pt}
>>> --
>>> 1.9.1
>>>
>>> --
>>> To unsubscribe from this list: send the line "unsubscribe perfbook" in
>>> the body of a message to majordomo@xxxxxxxxxxxxxxx
>>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>>
>>
>
--
To unsubscribe from this list: send the line "unsubscribe perfbook" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux