> On 21 Jun 2020, at 1:20 pm, Dan Kegel <dank@xxxxxxxxx> wrote: > > Openssl should probably stop using generic identifiers like freefunc > in its header files, out of sheer self-defense. I'd long held an apparently minority opinion among OpenSSL team members that prototypes in header files MUST NOT name any variables, and should only mention their types, precisely to avoid this sort of issue. Thus, e.g.: int foo(char *, int); rather than: int foo(char *buf, int len); Variable names in header files are no substitute for documentation, and are all too prone to precisely this sort of conflict. -- Viktor.
