> From: perumal v <sanperumalv@xxxxxxxxx> > Sent: Wednesday, 4 November, 2020 02:13 > change is highlighted below and basically keeping [] brackets for ipv6 : > > OCSP_parse_url > p = host; > if (host[0] == '[') { > /* ipv6 literal */ > // host++; > p = strchr(host, ']'); > if (!p) > goto parse_err; > // *p = '\0'; > p++; > } > Is this the correct way to do so? Based on my very cursory investigation, that looks right to me, but I don't know where else OCSP_parse_url might be used, and whether anything else depends on the existing semantics of removing the brackets. Someone should take a closer look. You could open an issue in GitHub and do a pull request for your change, to make your suggestion official. -- Michael Wojcik