Correct the check of RSA_FLAG_SIGN_VER

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Honeywell Internal

 

I think I have an answer for why this commit needed to be reverted:

Author:                Dr. Stephen Henson <steve@xxxxxxxxxxx>

Author date:      2 years ago (12/20/2015 10:18:43 AM)

Commit date:    2 years ago (12/20/2015 11:27:03 AM)

Commit hash:    6656ba7152dfe4bba865e327dd362ea08544aa80

Children:              1c7de36f62

Parent(s):            17592f323a

 

Don't check RSA_FLAG_SIGN_VER.

 

Reviewed-by: Richard Levitte <levitte@xxxxxxxxxxx>

 

The change made in that commit was to simply remove the attempt to check for the RSA_FLAG_SIGN_VER flag. But that’s not what is wrong with this code that required changing.

The change should be to add “meth” prior to flags:

 

@@ -84,7 +89,7 @@ int RSA_sign(int type, const unsigned char *m, unsigned int m_len,

         return 0;

     }

#endif

-    if ((rsa->flags & RSA_FLAG_SIGN_VER) && rsa->meth->rsa_sign) {

+    if ((rsa->meth->flags & RSA_FLAG_SIGN_VER) && rsa->meth->rsa_sign) {

         return rsa->meth->rsa_sign(type, m, m_len, sigret, siglen, rsa);

     }

     /* Special case: SSL signature, just check the length */

@@ -293,7 +298,7 @@ int RSA_verify(int dtype, const unsigned char *m, unsigned int m_len,

                const unsigned char *sigbuf, unsigned int siglen, RSA *rsa)

{

 

-    if ((rsa->flags & RSA_FLAG_SIGN_VER) && rsa->meth->rsa_verify) {

+    if ((rsa->meth->flags & RSA_FLAG_SIGN_VER) && rsa->meth->rsa_verify) {

         return rsa->meth->rsa_verify(dtype, m, m_len, sigbuf, siglen, rsa);

     }

 

--

 

-Ike-

  John Eichenberger

Intermec by Honeywell
Principal Engineer: Sustaining Engineering

425.921.4507

-- 
openssl-users mailing list
To unsubscribe: https://mta.openssl.org/mailman/listinfo/openssl-users

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux