you're quite right, not sure why we never caught this before!
On Fri, 28 Jun 2024, Corinna Vinschen wrote:
> Hi Damien,
>
> On Jun 18 12:46, Damien Miller wrote:
> > Hi,
> >
> > OpenSSH 9.8p1 is almost ready for release, so we would appreciate testing
> > on as many platforms and systems as possible. This is a bugfix release.
>
> Builds on current Cygwin and all tests pass, except a single command
> in a single test:
>
> run test sftp-cmds.sh ...
> sftp commands: lls
> lls failed
>
> Every other test in sftp-cmds.sh works, just this one lls test
> constantly fails for me.
>
> I found that the current working directory when starting sftp -D is the
> regress source dir, in my case:
>
> /home/corinna/openssh-9.8p0-1.x86_64/src/openssh-portable/regress
>
> When calling sftp in the lls test, it's asked to change the working
> dir to the build regress dir, i.e.:
>
> printf "cd ${OBJ}\nlls\n" | ${SFTP} -D ${SFTPSERVER} 2>&1 |
> grep copy.dd >/dev/null || fail "lls failed"
>
> That's correct, because the copy.dd file is created in ${OBJ}.
>
> In my case of building outside the source dir, $OBJ is
>
> /home/corinna/openssh-9.8p0-1.x86_64/build/regress
>
> However, `cd' only changes the remote dir. This doesn't affect
> the subsequent `lls' command which still has its local working dir
> set to the source dir.
>
> Consequentially, lls fails.
>
> Shouldn't `cd' actually be `lcd' in this test to be independent
> of building inside or outside the source dir?
>
>
> Thanks,
> Corinna
>
> _______________________________________________
> openssh-unix-dev mailing list
> openssh-unix-dev@xxxxxxxxxxx
> https://lists.mindrot.org/mailman/listinfo/openssh-unix-dev
>
_______________________________________________
openssh-unix-dev mailing list
openssh-unix-dev@xxxxxxxxxxx
https://lists.mindrot.org/mailman/listinfo/openssh-unix-dev
