On Sun, Nov 06, 2022 at 04:25:43PM -0500, Ed Maste wrote:
[...]
> Looks good to me, even if I think the multi-stage short-circuit is a
> little less clear.
It reads ok to me but I don't feel strongly either way.
In your diff, you check for it returning 0, however I note that the
procctl(2) man page does not specify what is returned on success in
the RETURN VALUES section (nor in the PROC_TRACE_CTL section or any
other place I can see):
"""
RETURN VALUES
If an error occurs, a value of -1 is returned and errno is set to
indicate the error.
"""
--
Darren Tucker (dtucker at dtucker.net)
GPG key 11EAA6FA / A86E 3E07 5B19 5880 E860 37F4 9357 ECEF 11EA A6FA (new)
Good judgement comes with experience. Unfortunately, the experience
usually comes from bad judgement.
_______________________________________________
openssh-unix-dev mailing list
openssh-unix-dev@xxxxxxxxxxx
https://lists.mindrot.org/mailman/listinfo/openssh-unix-dev
