Re: [PATCH] Improve endian conversion in umac.c

[Date Prev] [Date Next] [Thread Prev] [Thread Next] [Date Index] [Thread Index]

 



rapier:

> Versions tested:
> Stock openssh 8.8p1 (stock)
> Migrating all endian functions from misc.c (full)
> Migrating only [get|put]_u32_le from misc.c (little)

put_u32_le() isn't used anywhere.

And a quick look at the code shows that indeed get_u32_le() is used
to process _all_ data to be hashed.  Any other endian functions
aren't called in tight loops.

clang on amd64 optimizes these functions to a simple mov or mov+bswap.
I'm kinda curious whether PPC and SPARC compilers are smart enough
to use the load-swapped instructions.

-- 
Christian "naddy" Weisgerber                          naddy@xxxxxxxxxxxx
_______________________________________________
openssh-unix-dev mailing list
openssh-unix-dev@xxxxxxxxxxx
https://lists.mindrot.org/mailman/listinfo/openssh-unix-dev



[Date Prev] [Date Next] [Thread Prev] [Thread Next] [Date Index] [Thread Index]

[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux