Re: avoid sending pointer values in struct passwd

[Date Prev] [Date Next] [Thread Prev] [Thread Next] [Date Index] [Thread Index]

 



Yuichiro NAITO wrote:
> Take a look at my GitHub pull request to see my patch.
> 
> https://github.com/openssh/openssh-portable/pull/216

I think the length at the beginning should be tied to the (number of?)
members that are sent instead of the struct passwd size on either side.

Also, adding passwd.fields seems to be an unrelated change, better
placed in a separate commit.

Finally, sshbuf_free_passwd() is added but never called. If it is not
needed then I think it's better to not add it (yet).


//Peter
_______________________________________________
openssh-unix-dev mailing list
openssh-unix-dev@xxxxxxxxxxx
https://lists.mindrot.org/mailman/listinfo/openssh-unix-dev



[Date Prev] [Date Next] [Thread Prev] [Thread Next] [Date Index] [Thread Index]

[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux