On Fri, 5 Jun 2020, Peter Stuge wrote: > Darren Tucker wrote: > > Annotating these points with a FALLTHROUGH macro would make more > > work keeping the code in sync and so is currently a non-starter. > > Upstream OpenSSH/OpenBSD has no interest in embracing such a macro? It cannot be implemented as macro, because cpp normally strips comments on expansion (unless -Wp,-CC is given), so you cannot define it to expand to /* FALLTHROUGH */ for other compilers and lint. It’s also KNF to use the comment. bye, //mirabilos -- tarent solutions GmbH Rochusstraße 2-4, D-53123 Bonn • http://www.tarent.de/ Tel: +49 228 54881-393 • Fax: +49 228 54881-235 HRB 5168 (AG Bonn) • USt-ID (VAT): DE122264941 Geschäftsführer: Dr. Stefan Barth, Kai Ebenrett, Boris Esser, Alexander Steeg _______________________________________________ openssh-unix-dev mailing list openssh-unix-dev@xxxxxxxxxxx https://lists.mindrot.org/mailman/listinfo/openssh-unix-dev
