Hello, just raising a minor issue in sk-usbhid.c
At the moment, fido_init() is not being called except when SK_DEBUG is
enabled (which normally isn't):
#ifdef SK_DEBUG
fido_init(FIDO_DEBUG);
#endif
That exists in two places. I mentioned this in passing on the libfido2
tracker and the response is:
https://github.com/Yubico/libfido2/issues/166#issuecomment-622991151
"Regarding OpenSSH and fido_init(), OpenSSH should be calling
fido_init(). There are currently no ill effects from not calling it, but
that might change in the future."
So I'd suggest changing to something like:
#ifdef SK_DEBUG
fido_init(FIDO_DEBUG);
#else
fido_init(0);
#endif
- or define a new macro with value 0 or FIDO_DEBUG as appropriate.
Regards,
Brian.
_______________________________________________
openssh-unix-dev mailing list
openssh-unix-dev@xxxxxxxxxxx
https://lists.mindrot.org/mailman/listinfo/openssh-unix-dev
