On 2020-04-26, David Newall <openssh@xxxxxxxxxxxxxxx> wrote: > As a matter of principle, I argue against accepting patches like this > one. It achieves nothing of merit, and it introduces noise when > comparing different versions. The merit is that it prevents confusion (or at least, a double-take) for anyone reading this code for the remainder of its lifetime, especially since the '*' character is often used as the multiplication operator, and here it is adjacent to the word "negative", which further increases this association. Personally, I think this outweighs the one-time tiny bit of noise between the two versions. _______________________________________________ openssh-unix-dev mailing list openssh-unix-dev@xxxxxxxxxxx https://lists.mindrot.org/mailman/listinfo/openssh-unix-dev
