Hello, I noticed that the rsa_n, dsa_n, and ecdsa_n keys in sshkey testdata are not actually in the new format. They get copied from the PEM-format keys, but are never converted. When updating mktestdata.sh, I found a few other issues, so I fixed those as well. Michael Forney (4): Remove obsolete SSH1 testdata Update mktestdata.sh for new ssh-keygen defaults Delete newline after processing with sed Fix new-format sshkey testdata regress/unittests/sshkey/mktestdata.sh | 32 +++++++++-------- regress/unittests/sshkey/testdata/dsa_n | 33 +++++++++++------- regress/unittests/sshkey/testdata/ecdsa_n | 13 ++++--- regress/unittests/sshkey/testdata/rsa1_1 | Bin 533 -> 0 bytes regress/unittests/sshkey/testdata/rsa1_1.fp | 1 - .../unittests/sshkey/testdata/rsa1_1.fp.bb | 1 - .../unittests/sshkey/testdata/rsa1_1.param.n | 1 - regress/unittests/sshkey/testdata/rsa1_1.pub | 1 - regress/unittests/sshkey/testdata/rsa1_1_pw | Bin 533 -> 0 bytes regress/unittests/sshkey/testdata/rsa1_2 | Bin 981 -> 0 bytes regress/unittests/sshkey/testdata/rsa1_2.fp | 1 - .../unittests/sshkey/testdata/rsa1_2.fp.bb | 1 - .../unittests/sshkey/testdata/rsa1_2.param.n | 1 - regress/unittests/sshkey/testdata/rsa1_2.pub | 1 - regress/unittests/sshkey/testdata/rsa_n | 31 ++++++++-------- 15 files changed, 63 insertions(+), 54 deletions(-) delete mode 100644 regress/unittests/sshkey/testdata/rsa1_1 delete mode 100644 regress/unittests/sshkey/testdata/rsa1_1.fp delete mode 100644 regress/unittests/sshkey/testdata/rsa1_1.fp.bb delete mode 100644 regress/unittests/sshkey/testdata/rsa1_1.param.n delete mode 100644 regress/unittests/sshkey/testdata/rsa1_1.pub delete mode 100644 regress/unittests/sshkey/testdata/rsa1_1_pw delete mode 100644 regress/unittests/sshkey/testdata/rsa1_2 delete mode 100644 regress/unittests/sshkey/testdata/rsa1_2.fp delete mode 100644 regress/unittests/sshkey/testdata/rsa1_2.fp.bb delete mode 100644 regress/unittests/sshkey/testdata/rsa1_2.param.n delete mode 100644 regress/unittests/sshkey/testdata/rsa1_2.pub -- 2.26.2 _______________________________________________ openssh-unix-dev mailing list openssh-unix-dev@xxxxxxxxxxx https://lists.mindrot.org/mailman/listinfo/openssh-unix-dev