Re: Call for testing: OpenSSH 8.1

[Date Prev] [Date Next] [Thread Prev] [Thread Next] [Date Index] [Thread Index]

 



On Tue, 2019-10-01 at 21:33 +1000, Damien Miller wrote:
> Hi,
> 
> OpenSSH 8.1p1 is almost ready for release, so we would appreciate
> testing
> on as many platforms and systems as possible. This is a bugfix
> release.
> 
> Snapshot releases for portable OpenSSH are available from
> http://www.mindrot.org/openssh_snap/

During some patching, I noticed excessive includes of stdlib.h in some
of the files. The duplicates are removed with the attached patch or on
github:

https://github.com/Jakuje/openssh-portable/commit/88038f85

Regards,
-- 
Jakub Jelen
Senior Software Engineer
Security Technologies
Red Hat, Inc.
From 88038f8535b3602a412cce1aa5d0003a1d328be3 Mon Sep 17 00:00:00 2001
From: Jakub Jelen <jjelen@xxxxxxxxxx>
Date: Tue, 1 Oct 2019 14:31:55 +0200
Subject: [PATCH] Remove double stdlib.h

Signed-off-by: Jakub Jelen <jjelen@xxxxxxxxxx>
---
 hmac.c      | 1 -
 krl.c       | 1 -
 mac.c       | 1 -
 sftp-glob.c | 1 -
 4 files changed, 4 deletions(-)

diff --git a/hmac.c b/hmac.c
index a79e8569..32688876 100644
--- a/hmac.c
+++ b/hmac.c
@@ -21,7 +21,6 @@
 
 #include <stdlib.h>
 #include <string.h>
-#include <stdlib.h>
 
 #include "sshbuf.h"
 #include "digest.h"
diff --git a/krl.c b/krl.c
index 10a8bcc8..a7f69095 100644
--- a/krl.c
+++ b/krl.c
@@ -29,7 +29,6 @@
 #include <string.h>
 #include <time.h>
 #include <unistd.h>
-#include <stdlib.h>
 
 #include "sshbuf.h"
 #include "ssherr.h"
diff --git a/mac.c b/mac.c
index de346ed2..f3dda669 100644
--- a/mac.c
+++ b/mac.c
@@ -30,7 +30,6 @@
 #include <stdlib.h>
 #include <string.h>
 #include <stdio.h>
-#include <stdlib.h>
 
 #include "digest.h"
 #include "hmac.h"
diff --git a/sftp-glob.c b/sftp-glob.c
index 43a1beba..ce19aa84 100644
--- a/sftp-glob.c
+++ b/sftp-glob.c
@@ -25,7 +25,6 @@
 #include <dirent.h>
 #include <stdlib.h>
 #include <string.h>
-#include <stdlib.h>
 
 #include "xmalloc.h"
 #include "sftp.h"
-- 
2.21.0

_______________________________________________
openssh-unix-dev mailing list
openssh-unix-dev@xxxxxxxxxxx
https://lists.mindrot.org/mailman/listinfo/openssh-unix-dev

[Date Prev] [Date Next] [Thread Prev] [Thread Next] [Date Index] [Thread Index]

[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux