Re: [PATCH] Fix memory leak in 'handle' allocated through function 'get_handle'

[Date Prev] [Date Next] [Thread Prev] [Thread Next] [Date Index] [Thread Index]

 



On 25.09.2019 08:51, krishnaiah bommu wrote:
> ---
>  sftp-client.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/sftp-client.c b/sftp-client.c
> index 4fb6181..df76b7a 100644
> --- a/sftp-client.c
> +++ b/sftp-client.c
> @@ -632,6 +632,7 @@ do_lsreaddir(struct sftp_conn *conn, const char *path, int print_flag,
>  				free(filename);
>  				free(longname);
>  				sshbuf_free(msg);
> +				free(handle);
>  				return -1;

I have not carefully checked, but it looks like it still leaks everything pointed by (*dir). I'd rather probably considered (beware: totally untested)

- 				sshbuf_free(msg);
-  				return -1;
+                               goto out;

>  			}
>  
>
_______________________________________________
openssh-unix-dev mailing list
openssh-unix-dev@xxxxxxxxxxx
https://lists.mindrot.org/mailman/listinfo/openssh-unix-dev



[Date Prev] [Date Next] [Thread Prev] [Thread Next] [Date Index] [Thread Index]

[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux