Re: [PATCH] configure.ac: Add mandoc as valid formatter

[Date Prev] [Date Next] [Thread Prev] [Thread Next] [Date Index] [Thread Index]

 



Hi,

Ingo Schwarze <schwarze@xxxxxxx> wrote:

> Thanks for reporting.  I agree very much with the principle.  Strange
> no one from Void Linux or Alpine Linux reported this issue before...

I had a look at Void's and Alpine's build scripts, and they both
explicitly set --with-mantype=doc. I'm assuming the issue was known but
never reported upstream since it'd imply more work and friction than
committing a quick local change. I'm planning to make this fix known to
the maintainers of the scripts once it's merged.

> However, i'd suggest
> 
> 	AC_PATH_PROGS([NROFF], [nroff mandoc awf], ...
> 
> Otherwise, you get this strange output from ./configure
> when both are installed, needlessly confusing users:
> 
> 	checking for nroff... /usr/local/bin/nroff
> 	checking for mandoc... /usr/bin/mandoc
> 	[...]
> 	checking for mandoc... (cached) /usr/local/bin/nroff
> 
> The reason for this confusing output is that the first and the last of
> these lines both use the variable NROFF, so they should also better
> log "checking for nroff...", hence let's keep nroff first.
> The final value of the NROFF variable doesn't matter, it isn't used
> for anything in the build.

Had not spotted this in my tests and wasn't aware of this behaviour at
all - I agree that we should keep nroff first in this case.

Wolfgang
_______________________________________________
openssh-unix-dev mailing list
openssh-unix-dev@xxxxxxxxxxx
https://lists.mindrot.org/mailman/listinfo/openssh-unix-dev



[Date Prev] [Date Next] [Thread Prev] [Thread Next] [Date Index] [Thread Index]

[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux