Hi, The global variable tun_fwd_ifnames is used in both session.c and serverloop.c. This means one of them has to be marked as extern. Most compilers will ignore such errors, but it's not correct. E.g. in gcc you can enable a stricter handling of global variables with -fno-common. See attached patch, which will mark it as extern in sessions.c. (the other variables in that block are already marked extern, so it seems fitting.) -- Hanno Böck https://hboeck.de/ mail/jabber: hanno@xxxxxxxxx GPG: FE73757FA60E4E21B937579FA5880072BBB51E42
--- a/session.c 2018-10-17 02:01:20.000000000 +0200 +++ b/session.c 2019-01-12 19:08:05.464448664 +0100 @@ -142,7 +142,7 @@ extern int startup_pipe; extern void destroy_sensitive_data(void); extern struct sshbuf *loginmsg; extern struct sshauthopt *auth_opts; -char *tun_fwd_ifnames; /* serverloop.c */ +extern char *tun_fwd_ifnames; /* serverloop.c */ /* original command from peer. */ const char *original_command = NULL;
_______________________________________________ openssh-unix-dev mailing list openssh-unix-dev@xxxxxxxxxxx https://lists.mindrot.org/mailman/listinfo/openssh-unix-dev
