While I appreciate the need to code it and test it regularly, Peter wrote a bit of notify code and provided it to Damien to essentially do what the API code into systemd already does seemingly which seems like remaking the wheel to me, and would still require ongoing maintenance and testing. The systemd API is developed and maintained external to openssh and is there specifically to make it easier for apps that want to become daemons to be able to be used effectively in the systemd environment. I hated the fact that most flavors of Linux moved to systemd from the init system but it's what we, the end users (companies with 100's of thousands of Linux instances running) have to live with and to have Redhat make changes to *your* code to include systemd enhancements (and other vendors that don't necessarily take their codebase from Redhat) I would think would/could lead to issues (like this one) ongoing. If *you as the developers included the API access as a configurable option then *we the consumer could move to your newer codebase products sooner and get the enhancements that you folks work so diligently to make in your application which is a win-win for all of us. --- Regards, Kevin Martin On Thu, Aug 23, 2018 at 11:21 AM Emmanuel Deloget <logout@xxxxxxx> wrote: > Hello, > > On Thu, Aug 23, 2018 at 4:53 PM kevin martin <ktmdms@xxxxxxxxx> wrote: > > > > I'm not sure I agree with Peter in respect to his comment about > "building a > > dependency to systemd". The only time a "dependency" would be created is > > when the end-user would configure it to be there with a configure time > flag > > of --with-systemd. Just having the code available and dormant without > that > > flag being provided builds in no dependency whatsoever and gives the > > end-user their option to choose. > > Not sure I should step in, but the code to deal with the user > selection and to notify systemd is a dependency - even if it's > compiled out. The fact is that you still ave to maintain it and to > test it regularly. > > The problem looks like a systemd configuration error. systemd allows > you to start a non-systemd-aware daemon. You need to look at [Service] > / Type (notify is used for systemd-aware daemons). > > BR, > > -- Emmanuel Deloget > _______________________________________________ openssh-unix-dev mailing list openssh-unix-dev@xxxxxxxxxxx https://lists.mindrot.org/mailman/listinfo/openssh-unix-dev
