On Thu, 5 Apr 2018, Alex Wilson wrote: > On 04/04/18 21:56, Damien Miller wrote: > > > > I don't follow - clients always have to know that the last message sent > > was, otherwise they wouldn't be able to disambiguate the shared > > SSH_AGENT_SUCCESS / SSH_AGENT_FAILURE. > > The format of that message doesn't change though -- it's always a single > byte (so you don't need that information in the function that actually > parses the message). With this proposal that is no longer the case. I > mean, maybe it's a pointless concern and things are fine as proposed. I > wrote my client implementation to not have any of that state there for > parsing messages to make it easier to test and fuzz. I know other > implmentations don't necessarily do the same thing. ok, so what behaviour would you prefer? AFAIK the only way to be completely unambiguous would be to echo the full extension name in the reply, which seems unnecessarily verbose. -d _______________________________________________ openssh-unix-dev mailing list openssh-unix-dev@xxxxxxxxxxx https://lists.mindrot.org/mailman/listinfo/openssh-unix-dev
