Re: Call for testing: OpenSSH 7.6

[Date Prev] [Date Next] [Thread Prev] [Thread Next] [Date Index] [Thread Index]

 



On 29 September 2017 at 11:05, Iain Morgan <imorgan+openssh@xxxxxxxxxxxx> wrote:
[...]
> This is due to my shell being csh, which is pickier about undefined
> variables than the Bourne-style shells. The attached patch fixes the
> issue.

Thanks for figuring this out.

> -       'test -z "$SSH_USER_AUTH"' || fail "SSH_USER_AUTH present"
> +       'test -z `printenv SSH_USER_AUTH`' || fail "SSH_USER_AUTH present"

Unfortunately printenv is not specified by posix (AFAICT it's a
gnuism) so that would likely break many other currently working
platforms.
Would it be possible to do something like:

 'test -z `sh -c "echo $SSH_USER_AUTH"`' || fail "SSH_USER_AUTH present"

(plus or minus some quoting, probably) ?

-- 
Darren Tucker (dtucker at zip.com.au)
GPG key 11EAA6FA / A86E 3E07 5B19 5880 E860  37F4 9357 ECEF 11EA A6FA (new)
    Good judgement comes with experience. Unfortunately, the experience
usually comes from bad judgement.
_______________________________________________
openssh-unix-dev mailing list
openssh-unix-dev@xxxxxxxxxxx
https://lists.mindrot.org/mailman/listinfo/openssh-unix-dev



[Date Prev] [Date Next] [Thread Prev] [Thread Next] [Date Index] [Thread Index]

[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux