Hello, I wanted to check back in. It doesn't look like anyone has commented on the patch. Is there someone I should prod to get this looked at? Cheers, Ethan On Fri, Apr 7, 2017 at 11:39 AM, Ethan Rahn <ethan.rahn@xxxxxxxxx> wrote: > Ben, > > Thanks for the tip! I've added the patch to Bug 2705 on bugzilla. > > Cheers, > > Ethan > > On Fri, Apr 7, 2017 at 11:33 AM, Ben Lindstrom <mouring@xxxxxxxxxxxxxx> > wrote: > >> >> The mailinglist strips out attachments. So either you need to add it to >> the bug or post it in-line to the email. >> >> Ben >> >> Ethan Rahn wrote: >> >> Darren, >> >> Thanks, evidently I need to practice my reading skills. I did some practice >> on the style guide, and I believe that I have the patch fixed up per the >> style guidelines. I've attached the new patch to this email for review. >> >> Cheers, >> >> Ethan >> >> On Fri, Apr 7, 2017 at 5:02 AM, Darren Tucker <dtucker@xxxxxxxxxx> <dtucker@xxxxxxxxxx> wrote: >> >> >> On Fri, Apr 7, 2017 at 4:45 PM, Ethan Rahn <ethan.rahn@xxxxxxxxx> <ethan.rahn@xxxxxxxxx> wrote: >> >> >> To revive this thread - I filed a bug in bugzilla.mindrot.org ( Bug 2705 >> - https://bugzilla.mindrot.org/show_bug.cgi?id=2705 ). >> >> I have a patch attached to the email that implements this as well. I >> wasn't able to find a list of coding standards or contribution guidelines >> for OpenSSH, >> >> >> In general, the OpenBSD style guide. From the README: >> >> Code contribution are welcomed, but please follow the OpenBSD >> style guidelines[6]. >> [...] >> [6] http://man.openbsd.org/style.9 >> >> -- >> Darren Tucker (dtucker at zip.com.au) >> GPG key 11EAA6FA / A86E 3E07 5B19 5880 E860 37F4 9357 ECEF 11EA A6FA (new) >> Good judgement comes with experience. Unfortunately, the experience >> usually comes from bad judgement. >> >> >> _______________________________________________ >> openssh-unix-dev mailing listopenssh-unix-dev@mindrot.orghttps://lists.mindrot.org/mailman/listinfo/openssh-unix-dev >> >> >> > _______________________________________________ openssh-unix-dev mailing list openssh-unix-dev@xxxxxxxxxxx https://lists.mindrot.org/mailman/listinfo/openssh-unix-dev
