On Dec 18, 2016, at 11:15 PM, Jakob Schlyter <jakob@xxxxxxxx> wrote: > On 2016-12-18 at 19:07, Ron Frederick wrote: > >> While checking for “/tmp/launch” as a prefix is a problem now that MacOS is putting these local sockets in paths starting with “/private/tmp/com.apple.launchd”, I think this new code should at a minimum require that the path start with a leading “/“ before treating it as a local socket and doing a stat() on it. > > Even though this may be to late for 7.4, here's a patch: > > https://github.com/jschlyter/openssh-portable/commit/874603571f4eb7aa1ff8ff7cc1222de7ee973bbb > > Do we want an error logged as well? Thanks, Jakob - that patch looks good to me. I don’t think an error makes sense here. Anything not starting with a ‘/‘ would get handled as if it were a hostname (or one of the other special cases like “unix”), and there should already be error reporting in those places. -- Ron Frederick ronf@xxxxxxxxxxxxx _______________________________________________ openssh-unix-dev mailing list openssh-unix-dev@xxxxxxxxxxx https://lists.mindrot.org/mailman/listinfo/openssh-unix-dev
