On 07/22/2016 06:40 AM, Damien Miller wrote:
OpenSSH 5.3 is almost ready for release, so we would appreciate testing
on as many platforms and systems as possible. This release contains some
substantial new features and a number of bugfixes.
Testing with latest snap/git and applying our patches revealed only one
problem (when I don't count missing API for GSSAPI Kex, where we were
using get_canonical_hostname() also in the client code):
* Forgotten get_remote_ipaddr() function in audit-linux.c code
(attached patch)
Otherwise the package builds and passes all tests on current Fedora 24.
Regards,
--
Jakub Jelen
Security Technologies
Red Hat
diff --git a/audit-linux.c b/audit-linux.c
index b3ee2f4..4fd70a9 100644
--- a/audit-linux.c
+++ b/audit-linux.c
@@ -99,6 +99,7 @@ audit_session_close(struct logininfo *li)
void
audit_event(ssh_audit_event_t event)
{
+ struct ssh *ssh = active_state; /* XXX */
switch(event) {
case SSH_AUTH_SUCCESS:
case SSH_CONNECTION_CLOSE:
@@ -115,7 +116,7 @@ audit_event(ssh_audit_event_t event)
case SSH_AUTH_FAIL_GSSAPI:
case SSH_INVALID_USER:
linux_audit_record_event(-1, audit_username(), NULL,
- get_remote_ipaddr(), "sshd", 0);
+ ssh_remote_ipaddr(ssh), "sshd", 0);
break;
default:
_______________________________________________
openssh-unix-dev mailing list
openssh-unix-dev@xxxxxxxxxxx
https://lists.mindrot.org/mailman/listinfo/openssh-unix-dev
