On Jul 22 12:05, Corinna Vinschen wrote:
> On Jul 22 14:40, Damien Miller wrote:
> > Hi,
> >
> > OpenSSH 7.3 is almost ready for release, so we would appreciate testing
>
> This version doesn't build on Cygwin anymore. The reason is that
> various configure tests fail.
>
> The culprit is the new definition of IPPORT_RESERVED to 0 in configure.ac.
>
> After setting this value in configure, confdefs.h contains
>
> #define IPPORT_RESERVED 0
>
> netinet/in.h defines IPPORT_RESERVED as enum, just as on other systems:
>
> enum
> {
> [...]
> IPPORT_RESERVED = 1024,
> [...]
> };
>
> Since confdefs.h is evaluated *before* including any headers during
> configure, we have the following situation:
>
> #define IPPORT_RESERVED 0
> #include <netinet/in.h>
> --> enum { IPPORT_RESERVED = 1024 };
>
> which evaluates to
>
> enum { 0 = 1024 };
>
> which then leads to a compiler error:
>
> conftest.c:66:25: error: expected identifier before numeric constant
>
> and thus to a broken configuration.
>
> The same problem occurs when trying to build the source since config.h
> is included via includes.h prior to the system headers.
>
> So the simplification from NO_IPPORT_RESERVED_CONCEPT to just
> defining IPPORT_RESERVED as 0 doesn't work as desired.
>
> Can we revert this to the former NO_IPPORT_RESERVED_CONCEPT, please?
>
> I created the below patch which is less intrusive than the original
> patch. I tested that it works as desired and OpenSSH 7.3 builds
> on Cygwin.
>
> I have not *tested* OpenSSH7.3 on Cygwin yet. I'll report back in a
> followup mail.
All tests pass on current Cygwin with this patch applied.
Thanks,
Corinna
--
Corinna Vinschen
Cygwin Maintainer
Red Hat
Attachment:
signature.asc
Description: PGP signature
_______________________________________________ openssh-unix-dev mailing list openssh-unix-dev@xxxxxxxxxxx https://lists.mindrot.org/mailman/listinfo/openssh-unix-dev
