Hi Darren, On Apr 8 14:42, Darren Tucker wrote: > Hi. > > I while syncing an OpenBSD diff I got tripped up by > NO_IPPORT_RESERVED_CONCEPT which is in Portable and not OpenBSD so the > diff failed to apply. > > This diff replaces that #define by defining IPPORT_RESERVED=0, which > should have the same effect (since it's always compared to unsigfned 16bit > port numbers) but without a difference in the code. I vaguely recall > suggesting this once before, although if I did I didn't follow through. > > Corinna: does this seem reasonable? Instead of this awkward #ifndef, just set the lowest non-reserved port number to 0? That looks pretty good to me. Please note that we have IPPORT_RESERVED set to 1024 in our headers for historical porting reasons. However, it's an enum value so it can be easily overloaded with a macro. Thanks, Corinna -- Corinna Vinschen Cygwin Maintainer Red Hat
Attachment:
signature.asc
Description: PGP signature
_______________________________________________ openssh-unix-dev mailing list openssh-unix-dev@xxxxxxxxxxx https://lists.mindrot.org/mailman/listinfo/openssh-unix-dev
