On Wed, Feb 17, 2016 at 9:22 AM, Darren Tucker <dtucker@xxxxxxxxxx> wrote: [...] > - va_start(ap); > + va_start(ap, fmt); Actually that's not right either: "error: 'va_start' used in function with fixed args" I think the entire original commit is wrong and should be reverted: https://anongit.mindrot.org/openssh.git/commit/openbsd-compat/bsd-asprintf.c?id=0f754e29dd3760fc0b172c1220f18b753fb0957e -- Darren Tucker (dtucker at zip.com.au) GPG key 8FF4FA69 / D9A3 86E9 7EEE AF4B B2D4 37C9 C982 80C7 8FF4 FA69 Good judgement comes with experience. Unfortunately, the experience usually comes from bad judgement. _______________________________________________ openssh-unix-dev mailing list openssh-unix-dev@xxxxxxxxxxx https://lists.mindrot.org/mailman/listinfo/openssh-unix-dev