On Wed, Jan 20, 2016 at 10:54 AM, Ingo Schwarze <schwarze@xxxxxxx> wrote: >> $ grep -i mblen openbsd-compat/*.h >> openbsd-compat/openbsd-compat.h:#ifndef HAVE_MBLEN >> openbsd-compat/openbsd-compat.h:# define mblen(x, y) (1) > > Uh oh. I'm not quite sure what consequences that might entail in > libedit for sftp(1), which does use setlocale(LC_CTYPE, "")? > Did you audit those consequences? Audit? No. I spent a lot of time reading man pages but it's not something I've dealt with before so I don't understand it very well. That said, the behaviour on systems without mblen should be the same as what it was before my change so it should be no worse. The history is at https://bugzilla.mindrot.org/show_bug.cgi?id=1990 -- Darren Tucker (dtucker at zip.com.au) GPG key 8FF4FA69 / D9A3 86E9 7EEE AF4B B2D4 37C9 C982 80C7 8FF4 FA69 Good judgement comes with experience. Unfortunately, the experience usually comes from bad judgement. _______________________________________________ openssh-unix-dev mailing list openssh-unix-dev@xxxxxxxxxxx https://lists.mindrot.org/mailman/listinfo/openssh-unix-dev
