Re: wrong strlcat limit value in realpath.c

[Date Prev] [Date Next] [Thread Prev] [Thread Next] [Date Index] [Thread Index]

 



On Tue, 13 Oct 2015 12:36:45 -0700, William Ahern wrote:

> In realpath.c at line 182
> 
> 	left_len = strlcat(symlink, left, sizeof(left));
> 
> should be
> 
> 	left_len = strlcat(symlink, left, sizeof(symlink));
> 
> It's a benign issue because both arrays are the same size. And I can't
> imagine that ever changing. But it's inconsistent, not to mention throwing
> compiler warnings on OS X.

Correct.  This was fixed some time ago i version shipped with OpenSSH
was not updated.  The truncation check immediately following the
strlcat also should use sizeof(symlink) rather than sizeof(left).

 - todd
_______________________________________________
openssh-unix-dev mailing list
openssh-unix-dev@xxxxxxxxxxx
https://lists.mindrot.org/mailman/listinfo/openssh-unix-dev



[Date Prev] [Date Next] [Thread Prev] [Thread Next] [Date Index] [Thread Index]

[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux