Re: [PATCH] Expand tilde for UNIX domain socket forwards.

[Date Prev] [Date Next] [Thread Prev] [Thread Next] [Date Index] [Thread Index]

 



The name is not that bad, and the code looks ok.



On 19/08/15 04:31, Todd C. Miller wrote:
diff -u -p -u -r1.54 misc.h
--- misc.h	15 Jul 2014 15:54:14 -0000	1.54
+++ misc.h	19 Aug 2015 02:27:37 -0000
@@ -49,7 +49,8 @@
char *cleanhostname(char *);
char *colon(char *);
long convtime(const char *);
char *tilde_expand_filename(const char *, uid_t);
+int tilde_expand_filename2(const char *, char **, uid_t);
char *percent_expand(const char *, ...) __attribute__((__sentinel__));
char *tohex(const void *, size_t);
Note that here you are breaking the alignment of function names. (yep, completely minor)

_______________________________________________
openssh-unix-dev mailing list
openssh-unix-dev@xxxxxxxxxxx
https://lists.mindrot.org/mailman/listinfo/openssh-unix-dev



[Date Prev] [Date Next] [Thread Prev] [Thread Next] [Date Index] [Thread Index]

[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux