On Wed, 25 Mar 2015, Matthew Vernon wrote: > I had a look; ssh-keygen either exits 1 or 255 (via fatal). It's not > clear to me from reading the code what the rationale is for picking 1 or > 255; what is the intended difference in meaning between these two errors > (or alternatively, how do you decide whether to call fatal or print and > error and exit(1))? There's no rationale, just history. ssh-keygen probably needs tidying more than any other part of the codebase. IMO we should fatal() for errors and exit() only for cases where we want to return a meaningful signal via the return value. -d _______________________________________________ openssh-unix-dev mailing list openssh-unix-dev@xxxxxxxxxxx https://lists.mindrot.org/mailman/listinfo/openssh-unix-dev
