Re: Call for testing: OpenSSH 6.8

[Date Prev] [Date Next] [Thread Prev] [Thread Next] [Date Index] [Thread Index]

 



On 24/02/15 20:20, Damien Miller wrote:
On Tue, 24 Feb 2015, Tom G. Christensen wrote:
I don't know if it would be reasonable to include <netdb.h>
from includes.h but that would make HOST_NAME_MAX fall back to
MAXHOSTNAMELEN on at least Solaris < 10.

I guess we could do this:

diff --git includes.h includes.h
index c3034e3..ec74998 100644
--- includes.h
+++ includes.h
@@ -171,6 +171,8 @@
  #include <openssl/opensslv.h> /* For OPENSSL_VERSION_NUMBER */
  #endif

+#include <netdb.h> /* For MAXHOSTNAMELEN */
+
  #include "defines.h"

  #include "platform.h"


Exactly.
I tested such a change on Solaris 2.6 and it builds and HOST_NAME_MAX falls back to MAXHOSTNAMELEN.

I also had a quick look at a Solaris 10 host and it has _POSIX_HOST_NAME_MAX in <limits.h> which is already included.

-tgc
_______________________________________________
openssh-unix-dev mailing list
openssh-unix-dev@xxxxxxxxxxx
https://lists.mindrot.org/mailman/listinfo/openssh-unix-dev




[Date Prev] [Date Next] [Thread Prev] [Thread Next] [Date Index] [Thread Index]

[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux